SDKv2 PlanResourceChange truncates big integers

[VenelinMartinov]

What happened?

In pulumi/pulumi-gcp#2280 we discovered that PRC does not handle big integers correctly.

This needs to be addressed before rolling out PRC to GCP.

Example

.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[VenelinMartinov]

This seems to be 2 issues rolled up into one:

1. We truncate big integers when creating the resource because we do a round-trip to JSON, which uses float64, instead of json.Number.
2. We truncate big integers when running the upgradeState TF function.

1 is fixed by #2286

I have not yet been able to pull a repro for 2 in the bridge. I have also not had any luck in identifying the source of this - it seems to be TF but that should not be the case.

[VenelinMartinov]

The second truncation seems to be happening here:

pulumi-terraform-bridge/pkg/tfshim/sdk-v2/provider2.go

Line 357 in dac149b

newState, newMeta, err := upgradeResourceStateGRPC(ctx, t, res, state.stateValue, state.meta, p.server.gserver)

which calls the TF UpgradeResourceState GRPC here:

pulumi-terraform-bridge/pkg/tfshim/sdk-v2/upgrade_state.go

Line 47 in c6611a4

resp, err := server.UpgradeResourceState(ctx, &tfprotov5.UpgradeResourceStateRequest{

[VenelinMartinov]

The second truncation was an artefact of my local testing environment. I had the wrong version of the plugin-sdk checked out, which did not contain the latest modifications there (upstream-v2.33.0 instead of upstream-v2.33.0-with-272df8b).

This issue is fixed by #2286.