Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRC test failures in GCP #2280

Closed
3 tasks done
VenelinMartinov opened this issue Aug 2, 2024 · 1 comment
Closed
3 tasks done

PRC test failures in GCP #2280

VenelinMartinov opened this issue Aug 2, 2024 · 1 comment
Assignees
@VenelinMartinov
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone
0.108

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Aug 2, 2024 •
edited
Loading

Describe what happened

When enabling PRC by default we got some test failures. We need to root-cause and see if they are legitimate.

#2277

Sample program

.

Log output

No response

Affected Resource(s)

No response

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@VenelinMartinov VenelinMartinov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team kind/engineering Work that is not visible to an external user and removed kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Aug 2, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Aug 2, 2024
Closed
6 tasks
@VenelinMartinov
Copy link
Contributor Author

Unfortunately PRC seems to regress on #1036.

Will investigate some more.

This was referenced Aug 6, 2024
Closed
Merged
@VenelinMartinov VenelinMartinov self-assigned this Aug 8, 2024
@VenelinMartinov VenelinMartinov added the resolution/fixed This issue was fixed label Aug 8, 2024
@VenelinMartinov VenelinMartinov changed the title PRC test failures PRC test failures in GCP Aug 8, 2024
VenelinMartinov added a commit that referenced this issue Aug 9, 2024
@VenelinMartinov
Rework GCP labels tests to match TF (#2305)
abcc453 
The labels tests were asserting on behaviour different to what TF does.
The previous assumption was that "" in labels means keep old value but
that turns out is not quite correct.

Generally, "" is treated as "keep the previous value". However, if the
value has always been "", then it is treated as "no value". This trumps
any default labels.

This PR reworks the labels tests check to assert on the correct
behaviour, matching TF.

Stacked on #2277
Part of #2280
@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.108
Development

No branches or pull requests
2 participants
@mjeffryes @VenelinMartinov