Fix PRC big int creation #2286
Merged
Fix PRC big int creation #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
requested review from
t0yv0,
guineveresaenger,
iwahbe and
corymhall
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2286 +/- ##
==========================================
+ Coverage 56.71% 58.13% +1.42%
==========================================
Files 361 360 -1
Lines 49547 41567 -7980
==========================================
- Hits 28099 24167 -3932
+ Misses 19906 15848 -4058
- Partials 1542 1552 +10 ☔ View full report in Codecov by Sentry. |
t0yv0
reviewed
Aug 7, 2024
iwahbe
approved these changes
Aug 8, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big integers get truncated under PRC, even if treated as strings on the pulumi side. This means that #1896 does not work under PRC.
The reason for that is that we do a round trip to JSON when creating the resource where we truncate the integer. When decoding json numbers we have to use json.Number instead of the default float in order to not truncate 64 bit integers.
Fixes #2284