Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF Computed Set does not trigger diff when an element is removed #2192

Closed
VenelinMartinov opened this issue Jul 17, 2024 · 5 comments
Closed
Assignees
Labels
area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Jul 17, 2024

What happened?

During pulumi/pulumi-meraki#116 it was discovered that Computed + Optional Sets do not trigger a diff when an element is removed.

Possibly related to #2170

Note that the properties of the elements in the set here are not all computed.

Example

Repro in #2193

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added needs-triage Needs attention from the triage team kind/bug Some behavior is incorrect or out of spec area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes labels Jul 17, 2024
@t0yv0
Copy link
Member

t0yv0 commented Jul 17, 2024

Hopefully can be addressed by something like #2188 but will need to confirm.

@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Jul 17, 2024
@t0yv0 t0yv0 self-assigned this Jul 22, 2024
@t0yv0
Copy link
Member

t0yv0 commented Jul 22, 2024

I'll take it together with 2188.

@mjeffryes mjeffryes added this to the 0.108 milestone Jul 24, 2024
t0yv0 added a commit that referenced this issue Jul 26, 2024
OpenTofu planner code is now used with Plugin Framework providers to
emulate Terraform CLI behavior for `objchange.ProposedNew`. Note that
this code was already in use for SDKv2-based resources prior to the
change. The vendored code replaces a custom implementation that is now
removed.

Fixes #2172

Observable changes: Plugin Framework based resources may now reorder
outputs for Set collections.

This change is known to fix bugs such as
#2192 - to be
confirmed with a regression test in a follow-up PR.
@VenelinMartinov
Copy link
Contributor Author

@t0yv0 was this fixed in #2188 ? Should we merge a regression test for this and #2192

@VenelinMartinov
Copy link
Contributor Author

Updated the 2192 regression test in #2273

Also updated the 2170 repro in #2168

@t0yv0
Copy link
Member

t0yv0 commented Jul 31, 2024

In my understanding yes, it got fixed. Appreciate help getting the regression test in! 🙏

t0yv0 pushed a commit that referenced this issue Jul 31, 2024
@t0yv0 t0yv0 added the resolution/fixed This issue was fixed label Jul 31, 2024
@t0yv0 t0yv0 closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants