-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF Computed Set does not trigger diff when an element is removed #2192
Labels
area/plugin-framework
Support for Plugin Framework based providers
bug/diff
Bugs in computing Diffs and planning resource changes
kind/bug
Some behavior is incorrect or out of spec
resolution/fixed
This issue was fixed
Milestone
Comments
VenelinMartinov
added
needs-triage
Needs attention from the triage team
kind/bug
Some behavior is incorrect or out of spec
area/plugin-framework
Support for Plugin Framework based providers
bug/diff
Bugs in computing Diffs and planning resource changes
labels
Jul 17, 2024
This was referenced Jul 17, 2024
Hopefully can be addressed by something like #2188 but will need to confirm. |
I'll take it together with 2188. |
t0yv0
added a commit
that referenced
this issue
Jul 26, 2024
OpenTofu planner code is now used with Plugin Framework providers to emulate Terraform CLI behavior for `objchange.ProposedNew`. Note that this code was already in use for SDKv2-based resources prior to the change. The vendored code replaces a custom implementation that is now removed. Fixes #2172 Observable changes: Plugin Framework based resources may now reorder outputs for Set collections. This change is known to fix bugs such as #2192 - to be confirmed with a regression test in a follow-up PR.
Merged
In my understanding yes, it got fixed. Appreciate help getting the regression test in! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugin-framework
Support for Plugin Framework based providers
bug/diff
Bugs in computing Diffs and planning resource changes
kind/bug
Some behavior is incorrect or out of spec
resolution/fixed
This issue was fixed
What happened?
During pulumi/pulumi-meraki#116 it was discovered that Computed + Optional Sets do not trigger a diff when an element is removed.
Possibly related to #2170
Note that the properties of the elements in the set here are not all computed.
Example
Repro in #2193
Output of
pulumi about
.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: