Inconsistent Behavior When Removing Entries from vlanNames Array in VlanProfiles Resource

[zbuchheit]

Describe what happened

When attempting to remove an entry from the vlanNames after creating a VlanProfiles resource, it is not detecting a diff to trigger the removal of the entry.

related: #97

Sample program

1. pulumi up
2. pulumi refresh to pick up the diff
3. pulumi up to add the second field
4. remove a field from vlanNames
5. pulumi up
6. witness no diff

import * as meraki from "@pulumi/meraki";

const provider = new meraki.Provider("meraki-provider", {
  merakiDebug: "true",
});

const networks = meraki
  .getNetworksOutput({
    organizationId: "redacted",
  })
  .apply((networks) => {
    console.log(networks);
    return networks;
  });

const network = new meraki.networks.Base("base-network", {
  name: "Pulumi Test Network",
  notes: "This is a test network created by the Pulumi team",
  organizationId: "redacted",
  productTypes: ["appliance", "switch", "wireless", "cellularGateway"],
  timeZone: "America/Los_Angeles",
});

const vlanSettings = new meraki.networks.ApplianceVlansSettings(
  "vlan-settings",
  {
    networkId: network.id,
    vlansEnabled: true,
  },
  {
    provider: provider,
  }
);

const vlans = new meraki.networks.ApplianceVlans(
  "vlans",
  {
    networkId: network.id,
    applianceIp: "192.168.2.1",
    vlanId: "2",
    subnet: "192.168.2.0/24",
    name: "guest",
    dhcpHandling: "Do not respond to DHCP requests",
    dnsNameservers: "upstream_dns",
    dhcpLeaseTime: "1 day",
    dhcpBootOptionsEnabled: false,
  },
  { dependsOn: [vlanSettings], provider: provider }
);

const vlanProfiles = new meraki.networks.VlanProfiles(
  "vlan-profiles",
  {
    networkId: network.id,
    name: "Default Profile",
    iname: "Default",
    vlanNames: [
      {
        name: "default",
        vlanId: "1",
      },
      {
        name: vlans.name,
        vlanId: vlans.vlanId,
      },
    ],
    vlanGroups: [],
  },
  {
    provider: provider,
  }
);

Log output

No response

Affected Resource(s)

No response

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[zbuchheit]

when testing upstream I am not seeing this behavior

[VenelinMartinov]

Thanks for raising the issue @zbuchheit, I also appreciate the detailed reproes and the testing in TF here!

[VenelinMartinov]

Reproduced in the bridge: pulumi/pulumi-terraform-bridge#2192

We have some issues around sets in PF, we will take some time to improve thing here in the coming iteration.

[mjeffryes]

I see the bridge ticket is closed now; can we close this one yet? or do we need a bridge update first?

[t0yv0]

I think if we know which release of pulumi-meraki fixed the issue we can reference that and close.

[t0yv0]

Bridge v3.89.0 should contain the fix, I believe being released today. I'll check next week to see if we can update this dependency.

[t0yv0]

Fixed in #146