chore: remove minimal schema from source #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Nov 25, 2024
|
|
||
| //go:embed schema-minimal-embed.json | ||
| var pulumiMinimalSchema []byte | ||
| //go:embed schema-*-embed.json |
There was a problem hiding this comment.
The advantage of the * is that code still compiles even when minimal schema is not present on disk (such as upon checkout).
corymhall
approved these changes
Nov 26, 2024
|
I need one more tweak, but I think this can work. |
t0yv0
force-pushed
the
t0yv0/remove-minimal-schema-from-source
branch
from
c530820 to
c4d62fe
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
This PR has been shipped in release v6.62.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping a copy of minimal schema (introduced in #4587) is proving to conflict with Pulumi tooling such as
upgrade-providerand is not strictly necessary. With this change the minimal schema itself as well as CI checks to make sure it is up to date are removed. Instead it will be computed on-the-fly by the release job as before:GitHub actions invoke this:
pulumi-aws/.github/workflows/build_provider.yml
Line 60 in 916e6f2
Make extension ensures that this runs go generate prior to the actual build so that the minimal schema is re-computed:
pulumi-aws/.mk/minimal_schema.mk
Line 9 in 916e6f2
Fixes: