Builds: minimal schema computation not working with bridge upgrades #4702
Assignees
Labels
Comments
This was referenced Nov 6, 2024
|
The same is true for provider upgrades as well |
|
I'm not 100% sure but I think @corymhall fixed it in #4823 If he didn't I'll pick up on Monday to tidy it up. |
t0yv0
added a commit
that referenced
this issue
Nov 26, 2024
Keeping a copy of minimal schema (introduced in #4587) is proving to conflict with Pulumi tooling such as `upgrade-provider` and is not strictly necessary. With this change the minimal schema itself as well as CI checks to make sure it is up to date are removed. Instead it will be computed on-the-fly by the release job as before: - GitHub actions invoke this: https://github.com/pulumi/pulumi-aws/blob/916e6f28039407d7dcb1a295c6f9e43613dd6f87/.github/workflows/build_provider.yml#L60 - Make extension ensures that this runs go generate prior to the actual build so that the minimal schema is re-computed: https://github.com/pulumi/pulumi-aws/blob/916e6f28039407d7dcb1a295c6f9e43613dd6f87/.mk/minimal_schema.mk#L9 Fixes: - #4811 - #4702
|
This should be fixed in #4829 |
|
Cannot close issue:
Please fix these problems and try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what happened
https://github.com/pulumi/pulumi-aws/actions/runs/11614217568/job/32341851869?pr=4694
We need to either make sure it gets recomputed as part of
make tfgenor take it out of repo and compute it as part of build so it's not tracked in source.Sample program
N/A
Log output
N/A
Affected Resource(s)
N/A
Output of
pulumi aboutN/A
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: