-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream v5.72.0 #4647
base: master
Are you sure you want to change the base?
Upstream v5.72.0 #4647
Conversation
f67b23e
to
1074ad2
Compare
Does the PR have any schema changes?Found 1 breaking change: Types
New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
There's new deprecations rolling out, need to double-check this. |
@@ -204,6 +204,8 @@ namespace Pulumi.Aws.Iam | |||
/// | |||
/// ### Example of Exclusive Managed Policies | |||
/// | |||
/// > The `managed_policy_arns` argument is deprecated. Use the `aws.iam.RolePolicyAttachmentsExclusive` resource instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is actually a good thing. The inline managedPolicyArns
are a major foot gun.
I feel like by not surfacing that deprecation we might create more pain when the next major comes around and they possibly remove it (not sure that's upstream's plan though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussing internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4642