Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream v5.72.0 #4647

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Upstream v5.72.0 #4647

wants to merge 11 commits into from

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Oct 16, 2024

Fixes #4642

Copy link

github-actions bot commented Oct 16, 2024

Does the PR have any schema changes?

Found 1 breaking change:

Types

  • 🟡 "aws:workspaces/ConnectionAliasTimeouts:ConnectionAliasTimeouts": properties: "update" missing

New resources:

  • iam/rolePolicyAttachmentsExclusive.RolePolicyAttachmentsExclusive

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 16, 2024

      /**
  +     * Set of exclusive IAM managed policy ARNs to attach to the IAM role. If this attribute is not configured, Pulumi will ignore policy attachments to this resource. When configured, Pulumi will align the role's managed policy attachments with this set by attaching or detaching managed policies. Configuring an empty set (i.e., `managedPolicyArns = []`) will cause Pulumi to remove _all_ managed policy attachments.
  +     *
        * @deprecated The managedPolicyArns argument is deprecated. Use the aws.iam.RolePolicyAttachmentsExclusive resource instead.
        */

There's new deprecations rolling out, need to double-check this.

@@ -204,6 +204,8 @@ namespace Pulumi.Aws.Iam
///
/// ### Example of Exclusive Managed Policies
///
/// > The `managed_policy_arns` argument is deprecated. Use the `aws.iam.RolePolicyAttachmentsExclusive` resource instead.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is actually a good thing. The inline managedPolicyArns are a major foot gun.

I feel like by not surfacing that deprecation we might create more pain when the next major comes around and they possibly remove it (not sure that's upstream's plan though)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussing internally.

Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.72.0
2 participants