Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Exclusive Relationship Management Resources #4654

Closed
t0yv0 opened this issue Oct 17, 2024 · 1 comment · Fixed by #4769
Closed

Support Exclusive Relationship Management Resources #4654

t0yv0 opened this issue Oct 17, 2024 · 1 comment · Fixed by #4769
Assignees
@t0yv0
Labels
kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Milestone
0.113

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 17, 2024

There is a series of changes where upstream provider is deprecating but not removing popular attributes in favor of more side-by-side resources.

https://hashicorp.github.io/terraform-provider-aws/design-decisions/exclusive-relationship-management-resources
hashicorp/terraform-provider-aws#39376 (comment)

We need to look at how the pulumi-aws provider should handle these. In particular, migrating in Pulumi might need additional guidance specific to Pulumi, and building tooling to support it may require more effort.

To add some more links for inspecting the effect of these changes, https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.72.0 is one of the first releases where these changes are taking effect, and #4647 is our PR of upgrading the provider to match.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 17, 2024
@t0yv0 t0yv0 added kind/task Work that's part of an ongoing epic and removed needs-triage Needs attention from the triage team labels Oct 17, 2024
@t0yv0 t0yv0 added the p1 A bug severe enough to be the next item assigned to an engineer label Oct 25, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 25, 2024

Marking P1 to prioritize making a final decision here on how to translate this to Pulumi.

This was referenced Oct 25, 2024
Open
Merged
@t0yv0 t0yv0 self-assigned this Oct 28, 2024
t0yv0 added a commit that referenced this issue Oct 28, 2024
@t0yv0
Upstream v5.72.0 (#4647)
0e5b91d 
Upgrades upstream to
[v5.72.0](https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.72.0)

New resources:

- iam/rolePolicyAttachmentsExclusive.RolePolicyAttachmentsExclusive

In this release upstream has introduced deprecations for AWS IAM Role
inline_policy and managed_policy_arns arguments. These deprecations are
not yet propagated into the Pulumi provider
(#4654 tracks the context).

Fixes #4642
@mjeffryes mjeffryes added this to the 0.112 milestone Oct 30, 2024
@mjeffryes mjeffryes removed the p1 A bug severe enough to be the next item assigned to an engineer label Nov 12, 2024
@t0yv0 t0yv0 mentioned this issue Nov 13, 2024
Open
@mjeffryes mjeffryes modified the milestones: 0.112, 0.113 Nov 13, 2024
@t0yv0 t0yv0 mentioned this issue Nov 13, 2024
Merged
t0yv0 added a commit that referenced this issue Nov 14, 2024
@t0yv0
Remove aws.iam.Role inlinePolicies deprecation (#4769)
d13c832 
This change removes aws.iam.Role inlinePolicies deprecation until Pulumi
can support exclusive management resources better. In addition,
managedPolicyArns deprecation removal is moved from a patch to regular
code.

The deprecation removal affects SDK generators only - documentation may
still indicate that this is deprecated.

Context: #4654
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0yv0 t0yv0

Labels
kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.113
Development

Successfully merging a pull request may close this issue.

Remove aws.iam.Role inlinePolicies deprecation pulumi/pulumi-aws
3 participants
@t0yv0 @mjeffryes @pulumi-bot