Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream v5.68.0 #4523

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Upstream v5.68.0 #4523

merged 8 commits into from
Sep 25, 2024

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Sep 24, 2024 •
edited
Loading

Closes #4479

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Does the PR have any schema changes?

Found 4 breaking changes:

Types

  • 🟢 "aws:lex/V2modelsSlotTypeCompositeSlotTypeSetting:V2modelsSlotTypeCompositeSlotTypeSetting": required: "subSlots" property is no longer Required
  • "aws:lex/V2modelsSlotTypeCompositeSlotTypeSettingSubSlot:V2modelsSlotTypeCompositeSlotTypeSettingSubSlot":
    • 🟡 properties: "subSlotId" missing
    • required:
      • 🟢 "slotTypeId" property has changed to Required
      • 🟢 "subSlotId" property is no longer Required

New resources:

  • appsync/sourceApiAssociation.SourceApiAssociation
  • elasticache/reservedCacheNode.ReservedCacheNode
  • iam/rolePoliciesExclusive.RolePoliciesExclusive
  • pinpoint/smsvoicev2OptOutList.Smsvoicev2OptOutList
  • pinpoint/smsvoicev2PhoneNumber.Smsvoicev2PhoneNumber
  • sesv2/accountSuppressionAttributes.AccountSuppressionAttributes

New functions:

  • elasticache/getReservedCacheNodeOffering.getReservedCacheNodeOffering
  • securityhub/getStandardsControlAssociations.getStandardsControlAssociations
  • synthetics/getRuntimeVersion.getRuntimeVersion
  • synthetics/getRuntimeVersions.getRuntimeVersions

Maintainer note: consult the runbook for dealing with any breaking changes.

flostadler
flostadler approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

provider/resources.go
@@ -5822,4 +5822,10 @@ func setupComputedIDs(prov *tfbridge.ProviderInfo) {
prov.Resources["aws_lambda_function_recursion_config"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) {
return attr(state, "functionName"), nil
}
prov.Resources["aws_iam_role_policies_exclusive"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@corymhall corymhall merged commit 5af950d into master Sep 25, 2024
30 checks passed
@corymhall corymhall deleted the upstream-v5.68.0 branch September 25, 2024 12:23
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.53.0.

@pulumi-bot pulumi-bot mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flostadler flostadler flostadler approved these changes

@t0yv0 t0yv0 Awaiting requested review from t0yv0

Assignees

@corymhall corymhall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.68.0
3 participants
@corymhall @pulumi-bot @flostadler