Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform-provider-aws to v5.68.0 #4479

Closed
pulumi-bot opened this issue Sep 20, 2024 · 1 comment · Fixed by #4523
Closed

Upgrade terraform-provider-aws to v5.68.0 #4479

pulumi-bot opened this issue Sep 20, 2024 · 1 comment · Fixed by #4523
Assignees
@corymhall
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@pulumi-bot
Copy link
Contributor

Release details: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.68.0
@pulumi-bot pulumi-bot added the kind/enhancement Improvements or new features label Sep 20, 2024
corymhall added a commit that referenced this issue Sep 23, 2024
@corymhall
Update gamelift patches to sdkv2
42ed99a 
Upstream [recently made a change](hashicorp/terraform-provider-aws#39324)
so that a service cannot have resources across both sdkv1 and sdkv2.

This PR updates the `aws_gamelift_matchmaking_configuration` &
`aws_gamelift_matchmaking_rule_set` resources to sdkv2.

```console
$ make testacc TESTS=TestAccMatchmakingConfiguration PKG=gamelift
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run='TestAccMatchmakingConfiguration'  -timeout 360m
=== RUN   TestAccMatchmakingConfiguration_basic
=== PAUSE TestAccMatchmakingConfiguration_basic
=== RUN   TestAccMatchmakingConfiguration_tags
=== PAUSE TestAccMatchmakingConfiguration_tags
=== RUN   TestAccMatchmakingConfiguration_disappears
=== PAUSE TestAccMatchmakingConfiguration_disappears
=== CONT  TestAccMatchmakingConfiguration_basic
=== CONT  TestAccMatchmakingConfiguration_disappears
=== CONT  TestAccMatchmakingConfiguration_tags
--- PASS: TestAccMatchmakingConfiguration_disappears (12.48s)
--- PASS: TestAccMatchmakingConfiguration_tags (19.75s)
--- PASS: TestAccMatchmakingConfiguration_basic (27.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   31.040s
```

```console
$ make testacc TESTS=TestAccMatchmakingRuleSet PKG=gamelift
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run='TestAccMatchmakingRuleSet'  -timeout 360m
=== RUN   TestAccMatchmakingRuleSet_basic
--- PASS: TestAccMatchmakingRuleSet_basic (12.93s)
=== RUN   TestAccMatchmakingRuleSet_disappears
=== PAUSE TestAccMatchmakingRuleSet_disappears
=== CONT  TestAccMatchmakingRuleSet_disappears
--- PASS: TestAccMatchmakingRuleSet_disappears (10.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   27.193s
```

re #4479
@corymhall corymhall mentioned this issue Sep 23, 2024
Merged
corymhall added a commit that referenced this issue Sep 24, 2024
@corymhall
Update gamelift patches to sdkv2 (#4511)
e45ca74 
Upstream [recently made a
change](hashicorp/terraform-provider-aws#39324)
so that a service cannot have resources across both sdkv1 and sdkv2.

This PR updates the `aws_gamelift_matchmaking_configuration` &
`aws_gamelift_matchmaking_rule_set` resources to sdkv2.

```console
$ make testacc TESTS=TestAccMatchmakingConfiguration PKG=gamelift
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run='TestAccMatchmakingConfiguration'  -timeout 360m
=== RUN   TestAccMatchmakingConfiguration_basic
=== PAUSE TestAccMatchmakingConfiguration_basic
=== RUN   TestAccMatchmakingConfiguration_tags
=== PAUSE TestAccMatchmakingConfiguration_tags
=== RUN   TestAccMatchmakingConfiguration_disappears
=== PAUSE TestAccMatchmakingConfiguration_disappears
=== CONT  TestAccMatchmakingConfiguration_basic
=== CONT  TestAccMatchmakingConfiguration_disappears
=== CONT  TestAccMatchmakingConfiguration_tags
--- PASS: TestAccMatchmakingConfiguration_disappears (12.48s)
--- PASS: TestAccMatchmakingConfiguration_tags (19.75s)
--- PASS: TestAccMatchmakingConfiguration_basic (27.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   31.040s
```

```console
$ make testacc TESTS=TestAccMatchmakingRuleSet PKG=gamelift
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run='TestAccMatchmakingRuleSet'  -timeout 360m
=== RUN   TestAccMatchmakingRuleSet_basic
--- PASS: TestAccMatchmakingRuleSet_basic (12.93s)
=== RUN   TestAccMatchmakingRuleSet_disappears
=== PAUSE TestAccMatchmakingRuleSet_disappears
=== CONT  TestAccMatchmakingRuleSet_disappears
--- PASS: TestAccMatchmakingRuleSet_disappears (10.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   27.193s
```

re #4479
@corymhall corymhall mentioned this issue Sep 24, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 25, 2024
@pulumi-bot
Copy link
Contributor Author

This issue has been addressed in PR #4523 and shipped in release v6.53.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upstream v5.68.0 pulumi/pulumi-aws
2 participants
@pulumi-bot @corymhall