Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PRC by default in AWS #4403

Closed
wants to merge 6 commits into from
Closed

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Aug 26, 2024

Enables PlanResourceChange by default in pulumi-aws.

Part of pulumi/pulumi-terraform-bridge#1785

Also has a few test fixes.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@VenelinMartinov VenelinMartinov mentioned this pull request Aug 27, 2024
6 tasks
@t0yv0 t0yv0 self-requested a review August 28, 2024 15:20
VenelinMartinov added a commit that referenced this pull request Aug 29, 2024
The eks:Cluster resource has received a new parameter with ForceNew and
a default. When upgrading from an old version before the parameter was
added this triggers a replace.

This PR adds a workaround for that - when the state is read the
`bootstrapSelfManagedAddons` parameter is added with its default value
if not present.

covered by `TestEKSClusterUpgrade`

partially fixes #4410

stacked on #4403
@t0yv0
Copy link
Member

t0yv0 commented Sep 4, 2024

This got merged on the main branch.

@t0yv0 t0yv0 closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants