Enable zero default schema version in AWS #4416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2024
Closed
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
flostadler
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
The change itself (given acc tests pass) looks good to me. The rollout to other providers seemed to be smooth, so let's give it a go.
Rolling out PRC without this might unveil some more resources ending up being replaced (like #4415).
I'm curious what the others think. @t0yv0 seemed to have some concerns on the PR that introduced the state upgrade fix
iwahbe
approved these changes
Aug 28, 2024
|
Merging into the other PR to continue testing, LMK if there are any concerns here. |
VenelinMartinov
merged commit dcf0262
into
vvm/enable_prc_by_default
26 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll out pulumi/pulumi-terraform-bridge#2081 to AWS.
Part of pulumi/pulumi-terraform-bridge#2133