Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .Config.Publish.PublisherAction in favor of renovate #1229

Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 16, 2024

Follow-up on #1228.

This PR removes the .Config.Publish.PublisherAction option. It looks like .Config.Publisher.PublisherAction hasn't worked in the last 6 months: #1007. Given that it hasn't worked (presumably by accident) and that we have heard no complaints, it seems safe to remove the option and reduce the configuration complexity in ci-mgmt.

@iwahbe iwahbe requested review from blampe and a team December 16, 2024 09:37
@iwahbe iwahbe self-assigned this Dec 16, 2024
@ringods
Copy link
Member

ringods commented Dec 16, 2024

@iwahbe should the publisher action be listed here?

https://github.com/pulumi/ci-mgmt/blob/master/provider-ci/internal/pkg/action-versions.yml

It seems this file is created on purpose for Renovate to detect & match new versions.

Base automatically changed from update-pulumi-package-publisher-to-v0.0.21 to master December 16, 2024 10:07
Follow-up on #1228.

This PR removes the `.Config.Publish.PublisherAction` option. It looks like
.Config.Publisher.PublisherAction hasn't worked in the last 6 months: #1007. Given that it
hasn't worked (presumably by accident) and that we have heard no complaints, it seems safe
to remove the option and reduce the configuration complexity in `ci-mgmt`.
@iwahbe iwahbe force-pushed the iwahbe/remove-option-config-publisher-publisher-action branch from aa15c62 to aaca0c3 Compare December 16, 2024 10:20
@iwahbe
Copy link
Member Author

iwahbe commented Dec 16, 2024

@iwahbe should the publisher action be listed here?

https://github.com/pulumi/ci-mgmt/blob/master/provider-ci/internal/pkg/action-versions.yml

It seems this file is created on purpose for Renovate to detect & match new versions.

I don't think so, but I'm not 100% sure. That file was created by Renovate, so my assumption is that any necessary maintenance will also be done by Renovate. Renovate did update the publisher action before, and it was never in this file, so that gives me confidence.

@iwahbe iwahbe added this pull request to the merge queue Dec 16, 2024
Merged via the queue into master with commit 532904f Dec 16, 2024
6 checks passed
@iwahbe iwahbe deleted the iwahbe/remove-option-config-publisher-publisher-action branch December 16, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants