Update pulumi package publisher to v0.0.21 #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like we went from allowing the version to be controlled to pinned via renovate. Removing this option needs an actual decision, and the removal should be complete if it happens.
ringods
approved these changes
Dec 16, 2024
flostadler
approved these changes
Dec 16, 2024
iwahbe
added a commit
that referenced
this pull request
Dec 16, 2024
Follow-up on #1228. This PR removes the `.Config.Publish.PublisherAction` option. It looks like .Config.Publisher.PublisherAction hasn't worked in the last 6 months: #1007. Given that it hasn't worked (presumably by accident) and that we have heard no complaints, it seems safe to remove the option and reduce the configuration complexity in `ci-mgmt`.
iwahbe
added a commit
that referenced
this pull request
Dec 16, 2024
Follow-up on #1228. This PR removes the `.Config.Publish.PublisherAction` option. It looks like .Config.Publisher.PublisherAction hasn't worked in the last 6 months: #1007. Given that it hasn't worked (presumably by accident) and that we have heard no complaints, it seems safe to remove the option and reduce the configuration complexity in `ci-mgmt`.
|
Hey @iwahbe just to be clear, me bringing up this issue was a complain. We definitely rely on the nuget packages. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
Follow-up on #1228. This PR removes the `.Config.Publish.PublisherAction` option. It looks like .Config.Publisher.PublisherAction hasn't worked in the last 6 months: #1007. Given that it hasn't worked (presumably by accident) and that we have heard no complaints, it seems safe to remove the option and reduce the configuration complexity in `ci-mgmt`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the version of
pulumi-package-publisherused to v0.0.21.It looks like
.Config.Publisher.PublisherActionhasn't worked in the last 6 months: #1007. Given that it hasn't worked (presumably by accident) and that we have heard no complaints, I'm going to remove the functionality in a follow-up PR.Fixes pulumi/pulumi-package-publisher#44.