Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract test shared workflow #1034

Closed
danielrbradley opened this issue Jul 11, 2024 · 0 comments · Fixed by #1214
Closed

Extract test shared workflow #1034

danielrbradley opened this issue Jul 11, 2024 · 0 comments · Fixed by #1214
Assignees
@blampe
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@danielrbradley
Copy link
Member

The test job is currently duplicated in multiple workflows. The test process should be extracting into a single reusable workflow which can be called from each other top-level workflow.
@danielrbradley danielrbradley added the kind/engineering Work that is not visible to an external user label Jul 11, 2024
@danielrbradley danielrbradley mentioned this issue Jul 12, 2024
Closed
@blampe blampe mentioned this issue Dec 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@blampe
Consolidate test workflow (#1214)
3e4be1c 
* Updates `test-provider/aws/.ci-mgmt.yaml` to what's currently
checked-in.
* Consolidates test jobs into a shared workflow using
`run-acceptance-tests` as the starting point.

`extraTests` are included in the shared workflow mostly for simplicity.
This will break aws because those tests will specify `needs:` that are
no longer valid. We can fix that manually or just remove these extra
tests (pulumi/pulumi-aws#4910,
pulumi/pulumi-aws#4909).

No special treatment is given to TestPulumiExamples. We're not using
this outside of azure-native, and it should really just be treated like
any other integration test
#1211. If we don't want these
tests to run in certain workflows then we should expose some info to let
them `t.Skip` themselves.

Fixes #1034
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blampe blampe

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
3 participants
@danielrbradley @blampe @pulumi-bot