Simplify OIDC extraTest #4909
Merged
Simplify OIDC extraTest #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4909 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
to pulumi/ci-mgmt
that referenced
this pull request
Dec 12, 2024
* Updates `test-provider/aws/.ci-mgmt.yaml` to what's currently checked-in. * Consolidates test jobs into a shared workflow using `run-acceptance-tests` as the starting point. `extraTests` are included in the shared workflow mostly for simplicity. This will break aws because those tests will specify `needs:` that are no longer valid. We can fix that manually or just remove these extra tests (pulumi/pulumi-aws#4910, pulumi/pulumi-aws#4909). No special treatment is given to TestPulumiExamples. We're not using this outside of azure-native, and it should really just be treated like any other integration test #1211. If we don't want these tests to run in certain workflows then we should expose some info to let them `t.Skip` themselves. Fixes #1034
|
This PR has been shipped in release v6.65.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
TestAccCloudWatchandTestAccCloudWatchOidcManualare each executed twice. Once as part of thetest (nodejs, local)(examples) job, and again as part of thetest_oidcjob defined inextraTests.The
test_oidcjob executesTestAccCloudWatchOidcManualwithout any ambient AWS credentials, and thenTestAccCloudWatchafter assumingOIDC_ROLE_ARN.This PR removes the extra
test_oidcjob by incorporating these tests into the usual examples job.TestAccCloudWatchandTestAccCloudWatchOIDCAmbientpreserve the existing behavior of running these using the ambient credentials from the examples job. (Do we want to keep this?)TestAccCloudWatchOIDCManualandTestAccCloudWatchOIDCpreserving thetest_oidcbehavior by running without ambient credentials and after assumingOIDC_ROLE_ARN, respectively.