tcdm_err_slave: stall r_opc for 1 cycle #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The r_opc signal should come with the response signal (r_valid), a cycle after the req/gnt handshake. This change fixes a timing loop when using ibex as FC.
meggiman
approved these changes
May 3, 2022
bluewww
added a commit
that referenced
this pull request
May 5, 2023
After !77 This PR replaces legacy `RI5CY` with `CV32E40P` in either the SoC (FC controller) and the cluster (8 core instances) **HW (RTL)**: - [x] Replace cv32e40p with OBI adapter into SoC - [x] Add FPU wrapper into SoC using APU connection. FPU is now instantiated in `fc_subsystem` - [x] Replace cv32e40p with OBI adapter into Cluster - [x] Add `pulp_clock_gating` tech cell for ASIC, disable clock gating for FPGA (as in RI5CY) **[TODO: do it properly without using `ifdef`]** (#85) - [x] Add one [performance counters test](https://github.com/pulp-platform/regression_tests/tree/cv32perf_counters/perf_counters) in assembly for cv32 to be executed with pulp-runtime **SW**: Main SW changes concerns: 1. Different mapping of the HW loops (`Xpulp` extensions) 2. Different structure and mapping of the performance counters 3. Enable clint timer irq (Freertos and RTL) - [x] Change `PULP RISCV GCC toolchain` version used in the CI with cv32e40p target with: `/usr/pack/riscv-1.0-kgf/pulp-gcc-2.2.0` - [x] Update `pulp-runtime` with cv32e40p target with: `v0.0.9` - [x] Update `FreeRTOS` version with cv32e40p target with: `570b2c1c` **MISC** - [x] Update README - [x] Update CHANGELOG - The testset has been previously overhauled in !63 and !65. In particular !63 removed some tests that used the legacy pulp-sdk and RI5CY and were not a fit anymore with cv32 Within this project boundary, there exits three issues tracked in #87, #86 and #85 that will be addressed in separate MRs Fixes #59 #60 #84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The r_opc signal should come with the response signal (r_valid), a cycle after the req/gnt handshake. This change fixes a timing loop when using ibex as FC.