Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addr_decode: Add a variant suited for online configuration #198

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

thommythomaso
Copy link
Contributor

@thommythomaso thommythomaso commented Sep 26, 2023

Transient invalid rule configs during online configuration of the IP currently cause warning messages and could even throw fatals. This PR adds a DYNamic Configuration (DYNC) version of the IP with one additional input, bringing the IP to a well-known state and silencing all continuous assertions during reconfiguration.

Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general! Just one set of suggestions to remain consistent between logical and bitwise operators. Also, could you please rebase to resolve the merge conflicts? Sorry for that

src/addr_decode_dync.sv Outdated Show resolved Hide resolved
src/addr_decode_dync.sv Outdated Show resolved Hide resolved
src/addr_decode_dync.sv Outdated Show resolved Hide resolved
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@niwis niwis merged commit 7ecdec0 into master Sep 26, 2023
5 checks passed
@niwis niwis deleted the addr_decode_dync-tbenz branch September 26, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants