Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spatz python dependencies in Carfield top level #253

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

ezelioli
Copy link
Contributor

Spatz hw generation python scripts rely on two additional dependencies (jsonref, jsonschema) not listed in requirements.txt.

Moreover, the Spatz makefile will default to python3.6 if the PYTHON variable is not set. Therefore, changed it in carfield.mk to default to python3.

Finally, remove the duplicated hjson dependency.

@ezelioli ezelioli requested a review from alex96295 as a code owner February 22, 2024 14:19
Copy link
Collaborator

@alex96295 alex96295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before merging, can you please edit the docs with Python dependency requirement? We can have >= 3.0

@alex96295 alex96295 added documentation Improvements or additions to documentation bug-fix Something wasn't working and it is being fixed labels Feb 22, 2024
@bluewww
Copy link
Contributor

bluewww commented Feb 22, 2024

I don't thik python 3.0 is valid dependency as most of the libraries won't work at that version. It should be put to 3.6 which is the version used on alma linux 8

@yvantor
Copy link
Contributor

yvantor commented Feb 22, 2024

@ezelioli @alex96295 I wanted just to point out that with #245 we will be no longer using the generated Spatz wrapper, replaced by this

@alex96295
Copy link
Collaborator

@ezelioli @alex96295 I wanted just to point out that with #245 we will be no longer using the generated Spatz wrapper, replaced by this

We'll merge this since it's a fix and then incrementally add the other changes

@alex96295 alex96295 merged commit 64e8ef8 into main Feb 23, 2024
7 checks passed
@alex96295 alex96295 deleted the ez/dependencies branch February 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Something wasn't working and it is being fixed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants