Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW] Optimize addrgen for OS-on operation #383

Merged
merged 4 commits into from
Jan 14, 2025
Merged

[HW] Optimize addrgen for OS-on operation #383

merged 4 commits into from
Jan 14, 2025

Conversation

mp-17
Copy link
Collaborator

@mp-17 mp-17 commented Jan 6, 2025

Enable OS by default and optimize addrgen critical paths.

Most of the addrgen critical quantities are calculated in advance with the least dependencies possible.

For example, the expensive computation to find the AXI end address should not depend on the mmu_valid_i signal from CVA6, i.e., the virtual address computation should not depend on CVA6's answer.

The new address can be computed ahead of time and saved as "next request" as soon as CVA6 answers back with the previous physical address, while the old virtual address is kept constant with the translation request.

Changelog

Changed

  • Optimize addrgen for OS-on operation
  • Enable OS by default

Checklist

  • Automated tests pass
  • It works on FPGA
  • Changelog updated
  • Code style guideline is observed
  • Fix fof_exception red signal in addrgen

@mp-17 mp-17 force-pushed the feat/addrgen-opt-OS branch from 596b341 to 3fcf3d0 Compare January 7, 2025 16:59
@mp-17 mp-17 marked this pull request as ready for review January 8, 2025 15:13
@mp-17 mp-17 marked this pull request as draft January 8, 2025 15:13
@mp-17 mp-17 self-assigned this Jan 8, 2025
@mp-17 mp-17 force-pushed the feat/addrgen-opt-OS branch from 3fcf3d0 to 794397d Compare January 14, 2025 10:49
@mp-17 mp-17 marked this pull request as ready for review January 14, 2025 11:16
@mp-17 mp-17 force-pushed the feat/addrgen-opt-OS branch from 794397d to eda709a Compare January 14, 2025 15:26
@mp-17 mp-17 merged commit c385767 into main Jan 14, 2025
21 checks passed
@mp-17 mp-17 deleted the feat/addrgen-opt-OS branch January 14, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant