Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smoove domains #1328

Closed
wants to merge 2 commits into from
Closed

Add Smoove domains #1328

wants to merge 2 commits into from

Conversation

DanSmoove
Copy link
Contributor

@DanSmoove DanSmoove commented May 23, 2021

  • Description of Organization
    ====
    Organization Website: https://www.smoove.io We are an ESP and marketing platform that gives businesses from all over the world a full set of tools they can use for marketing. from newsletters to landing pages to full marketing automation.
    ====

  • Reason for PSL Inclusion
    ====
    We provide our customers the option to create landing pages using sub domains that are under our domains:
    vp4.me
    viplus.com
    smoove.io
    for example: danafb1.vp4.me
    We want to allow our customers to set aggregated measurements in Facebook Events Manager for their Facebook pixels for events that come from their subdomain that they choose on our platform (in accordance with Facebook's domain verification docs). The referenced domains have been registered until 2024.
    We also commit to maintaining more than 2 (two) years on our domain's registration
    ====

  • DNS verification via dig
    ====

dig +short TXT _psl.vp4.me
"https://github.com/publicsuffix/list/pull/1328"
dig +short TXT _psl.viplus.com
"https://github.com/publicsuffix/list/pull/1328"
dig +short TXT _psl.smoove.io
"https://github.com/publicsuffix/list/pull/1328"

====

  • Run Syntax Checker (make test)
    ====
    test succeded
    test output:
    test_allowedchars: OK
    test_dots: OK
    test_duplicate: OK
    test_exception: OK
    test_NFKC: OK
    test_punycode: OK
    test_section1: OK
    test_section2: OK
    test_section3: OK
    test_section4: OK
    test_spaces: OK
    test_wildcard: OK
    ====

@dnsguru
Copy link
Member

dnsguru commented May 24, 2021

Please see #1245 as to why this is filed as wontfix

@dnsguru dnsguru added IOS-FB? PR related to Issue #1245 / needs https://www.facebook.com/help/contact/474057987130813 ❌wontfix Will not be merged. Reason typically included in PR/Issue as to why labels May 24, 2021
@dnsguru dnsguru self-assigned this Jun 1, 2021
@n8schloss
Copy link

Posting to let you know that Facebook has updated our guidance to include a validation flow run by Facebook staff. We encourage anyone requesting addition to the PSL as it relates to Facebook and iOS 14 interactions to make a request directly to Facebook via the form linked from our Help Center Article: https://www.facebook.com/business/help/126789292407737

In the form, given that you have already raised a pull request here, please include a link to this pull request in the description.

We have agreed to do this to reduce the burden on PSL maintainers, ensure that you are asking to be on the PSL for the right reasons, and to allow us to collate and understand the issues that businesses are facing as part of this shift.

After Facebook has assessed one of these requests we will make a recommendation or no recommendation decision, the PSL maintainers will make the final determination and we will coordinate with them on next steps accordingly.

@dnsguru
Copy link
Member

dnsguru commented Jun 3, 2021

thanks @n8schloss - appreciate FB stepping up to address what can be addressed on this matter - the PSL as salvation was not as utopian as some of the early guidance suggested. Closing this - please reference its PR# if a new one is opened so there is case history.

Take a look at #1337 on their comment as to why they submitted and subsequently removed their PR - they will have to deal with the impacts that were unexpected for a few months while various browsers etc propogate to using the updated PSL, and the whole thing could have been avoided had there been no request in the first place.

@dnsguru dnsguru closed this Jun 3, 2021
@dnsguru dnsguru mentioned this pull request Jun 14, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IOS-FB? PR related to Issue #1245 / needs https://www.facebook.com/help/contact/474057987130813 ❌wontfix Will not be merged. Reason typically included in PR/Issue as to why
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants