Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting option highlighted in the image sidebar #825

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

divyabaid16
Copy link
Contributor

Fixes #796 (<=== Add issue number here)

The option by which the user sorts/orders the image is highlighted.

Selection_203

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

Thanks!

@codeclimate
Copy link

codeclimate bot commented Jul 9, 2019

Code Climate has analyzed commit 5fd94ce and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #825 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #825   +/-   ##
=======================================
  Coverage   72.43%   72.43%           
=======================================
  Files          35       35           
  Lines        1335     1335           
=======================================
  Hits          967      967           
  Misses        368      368

@jywarren
Copy link
Member

jywarren commented Jul 9, 2019

Hmm, still needing to resolve #810 -- perhaps @kaustubh-nair could use some help with it? I think it's affecting this here because CodeCov shouldn't be rejecting this!

@kaustubh-nair
Copy link
Member

Hmm image_controller coverage is at zero...
Let's try running this again and see what happens

@kaustubh-nair
Copy link
Member

Huh that worked..really weird..
@jywarren I believe we should turn off codecov/project since we don't need the entire project's coverage everytime. coverage/patch should be good enough for pull requests.
I've sent a pull here #830

@jywarren
Copy link
Member

OK, cool, well, I merged this in any case!

@divyabaid16 divyabaid16 deleted the sort-label branch July 11, 2019 05:08
chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show which sort on image is performed
3 participants