Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off project, turn on patch for codecov #830

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Conversation

kaustubh-nair
Copy link
Member

@kaustubh-nair kaustubh-nair commented Jul 10, 2019

Might fix #810
The inconsistency is arising from project. Let's try this and see if it fixes the codecov issue

@codeclimate
Copy link

codeclimate bot commented Jul 10, 2019

Code Climate has analyzed commit fee7c65 and detected 0 issues on this pull request.

View more on Code Climate.

@kaustubh-nair
Copy link
Member Author

@jywarren let's merge this and see what happens

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #830 into main will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   69.15%   69.17%   +0.02%     
==========================================
  Files          35       35              
  Lines        1355     1353       -2     
==========================================
- Hits          937      936       -1     
+ Misses        418      417       -1
Impacted Files Coverage Δ
app/controllers/annotations_controller.rb 0% <0%> (-59.26%) ⬇️
app/models/export.rb 69.44% <0%> (-30.56%) ⬇️
app/models/user.rb 92.85% <0%> (-7.15%) ⬇️
app/models/warpable.rb 85.22% <0%> (-2.28%) ⬇️
app/controllers/feeds_controller.rb 100% <0%> (+100%) ⬆️

@kaustubh-nair
Copy link
Member Author

Coverage decreased again?!
WHY !? 😕

@kaustubh-nair
Copy link
Member Author

I just realized that turning project or patch off won't make a difference. There's something wrong with the coverage reporter itself

@kaustubh-nair kaustubh-nair mentioned this pull request Jul 10, 2019
5 tasks
@jywarren jywarren merged commit 3d00a3f into main Jul 10, 2019
@jywarren
Copy link
Member

OK! Thanks!

@jywarren
Copy link
Member

Oh no! Was I not supposed to? Shall we revert? We may need to open another PR. But at least we're no worse off than we were. Thanks @kaustubh-nair I'm sure we'll figure it out! ❤️

@kaustubh-nair
Copy link
Member Author

Yeah this doesn't fix it
It's okay though, I'll open a new PR

chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistencies with CodeCov rejections
2 participants