Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB: support "best price search" #314
base: main
Are you sure you want to change the base?
DB: support "best price search" #314
Changes from all commits
92712c7
6591078
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, even though I told you to do it this way, I think this isn't correct either: For example, if
profile.timezone
isEurope/Berlin
, the timezone-naivenow
is2024-05-06T00:30+01:00
because it runs on a machine inEurope/London
, then this will create a Berlin-timezone timestamp for the next day.I can think of a least two options, the latter being the more straightforward one IMO:
now
to be timezone-aware, so thatnow.{year, month,day}
are correct.DateTime
calls, as illustrated below.Also, while implicitly casting
today
to anumber
below works, it would be cleaner to add.toMillis()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads-up: There might be a case – that I can't think of right now though – that fails because
transformJourneysQuery()
assumes aTripSearch
call.