DB: support "best price search" #314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
commented
Mar 20, 2024
bergmannjg
force-pushed
the
add-BestPriceSearch
branch
from
ce4b5b5 to
92712c7
Compare
derhuerst
commented
Mar 23, 2024
| const {res, common} = await profile.request({profile, opt}, userAgent, { | ||
| cfg: {polyEnc: 'GPA'}, | ||
| meth: 'BestPriceSearch', | ||
| req: profile.transformJourneysQuery({profile, opt}, query), |
There was a problem hiding this comment.
Just a heads-up: There might be a case – that I can't think of right now though – that fails because transformJourneysQuery() assumes a TripSearch call.
derhuerst
commented
May 5, 2024
| throw new TypeError('opt.departure is invalid'); | ||
| } | ||
| const now = new Date(); | ||
| let today = DateTime.fromObject({ |
There was a problem hiding this comment.
Sorry, even though I told you to do it this way, I think this isn't correct either: For example, if profile.timezone is Europe/Berlin, the timezone-naive now is 2024-05-06T00:30+01:00 because it runs on a machine in Europe/London, then this will create a Berlin-timezone timestamp for the next day.
I can think of a least two options, the latter being the more straightforward one IMO:
- Change
nowto be timezone-aware, so thatnow.{year, month,day}are correct. - Just use one chain of
DateTimecalls, as illustrated below.
Also, while implicitly casting today to a number below works, it would be cleaner to add .toMillis().
const today = DateTime
.fromMillis(Date.now(), {
zone: profile.timezone,
locale: profile.locale,
})
.startOf('day')
.toMillis()
|
remotely related: #331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bergmannjg I went ahead and created a WIP PR.
Fixes #291.
Fixes juliuste/db-prices#33.
Fixes derhuerst/db-prices-cli#4.