-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tracemalloc error when action isn't defined #161
Conversation
Which command line did you use to trigger this error? |
We're triggering the runner with our own script. That script calls another script with the relevant It's an odd way of invoking pyperf, I'll be the first to admit. This is legacy code I've been slowly cleaning up and modernizing. Perhaps using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, I can reproduce the issue with python3 doc/examples/bench_func.py --tracemalloc
command.
Co-authored-by: Victor Stinner <[email protected]>
@vstinner Is there anything else pending here that I can help with? |
@vstinner Can we get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ref #131
We're using the
Runner
's argument parsing, but without usingpyperf
directly. This is resulting in an undefinedaction
, which means that when we use the--tracemalloc
argument, we get the following error:This PR checks for the attribute before accessing it.