Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject --tracemalloc in pyperf command #131

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

oraluben
Copy link
Contributor

Close #130

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyperf/_runner.py Outdated Show resolved Hide resolved
@oraluben oraluben force-pushed the warn-tracemalloc-for-command branch from ef3f4cd to fdf0da8 Compare May 23, 2022 14:06
pyperf/_command.py Outdated Show resolved Hide resolved
@oraluben oraluben force-pushed the warn-tracemalloc-for-command branch 2 times, most recently from f306dbf to 7363cea Compare May 23, 2022 15:03
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@corona10
Copy link
Member

@oraluben I forgot to take look at this PR.
Would you like to rebase on 2.4.1?

@oraluben oraluben force-pushed the warn-tracemalloc-for-command branch from 7363cea to 080ccad Compare July 21, 2022 00:41
@oraluben oraluben force-pushed the warn-tracemalloc-for-command branch from 080ccad to 8d52cc6 Compare July 21, 2022 00:42
@oraluben
Copy link
Contributor Author

@corona10 done :)

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 1fd8dae into psf:main Jul 21, 2022
@oraluben oraluben deleted the warn-tracemalloc-for-command branch July 21, 2022 01:35
@vstinner
Copy link
Member

vstinner commented Aug 3, 2022

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when bench command with --tracemalloc
3 participants