Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: Add Python3.6 as available Python version #151

Closed
wants to merge 2 commits into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Nov 30, 2022

We dropped the support for Python 3.6 through #142.
Technically, it was available to be installed at Python 3.6 but since pyperformance still uses Python 3.6,
I think that we should sync the version support with the pyperformance team.

There was a restriction at pyproject.toml but it was never published to PyPI yet luckily.

@corona10
Copy link
Member Author

corona10 commented Nov 30, 2022

cc @ericsnowcurrently @mdboom

@corona10
Copy link
Member Author

Option A

  • Do not maintain Python 3.6 CI
  • Downgrade requires-python into Python 3.6

Option B

  • Maintain requires-python as Python 3.7
  • Drop support Python 3.6 at pyperformance too

Option C

  • Maintain Python 3.6 CI
  • Downgrade requires-python into Python 3.6

@vstinner
Copy link
Member

The CI failed with:

ERROR: Could not find a version that satisfies the requirement setuptools>=61

Is it possible to use older setuptools on Python <= 3.6?

pyproject.toml contains:

[build-system]
requires = ["setuptools >= 61"]
build-backend = "setuptools.build_meta"

Why is version 61 required?

@corona10
Copy link
Member Author

Why is version 61 required?

I think that we can downgrade into 59

@corona10
Copy link
Member Author

@vstinner @ericsnowcurrently @mdboom

There looks some issue between the new package meta system with setuptools and Python 3.6
If we still need to support Python 3.6, I would like to suggest rollback the package build system into setup.py.

@ericsnowcurrently
Copy link

After thinking about it, I wouldn't worry about supporting 3.6.

@corona10 corona10 closed this Dec 5, 2022
@vstinner
Copy link
Member

vstinner commented Dec 5, 2022

So pyperformance doesn't use Python 3.7 anymore?

@corona10
Copy link
Member Author

corona10 commented Dec 6, 2022

@vstinner we merged python/pyperformance#249, so no support only for 3.6 not 3.7

@corona10 corona10 deleted the 3.6 branch December 6, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants