Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #142

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Add support for Python 3.11 #142

merged 5 commits into from
Nov 4, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 4, 2022

Also drop support for EOL Python <= 3.6 and fix errors found running tox -e pep8.

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 0318d44 into psf:main Nov 4, 2022
@hugovk hugovk deleted the add-3.11 branch November 4, 2022 14:26
@vstinner
Copy link
Member

vstinner commented Nov 4, 2022

Also drop support for EOL Python <= 3.6

Does supporting support for Python 3.6 brings anything useful yet? I can easily be tested on a CI. I would prefer to keep it supported until it beaks badly and no one is volunteer to still support it.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 4, 2022

It removes a CI job, but that's not a big deal here.

I didn't upgrade the syntax for 3.7+, so it's fine to re-add it.

@vstinner
Copy link
Member

vstinner commented Nov 4, 2022

It's not a big deal. I'm also fine with removing Python 3.6 support. Especially, if technically Python 3.6 still works :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants