Folder level settings #268
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limarkxx
force-pushed
the
folder-level-settings
branch
from
3343b68 to
b0a390f
Compare
|
This looks great. Just need to play with it. I'm currently writing a test runner extension for php for vscode and I've switched to using resource as well so I agree with this overall |
|
I moved all the testing stuff to #269 because it was getting tough to read, and also I don't have any actual tests yet. |
|
vimeo/psalm#10094 prevents multiple LSP instances currently |
|
You can start a codespace in https://github.com/limarkxx/psalm-vscode-plugin/tree/test-folder-level-settings to test with a sample project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to support multi-root workspaces, by changing the scope of configuration setting contribution points to
resourceinstead of the defaultwindow, and fully supporting those changes in behavior.This should allow the user to configure unique psalm language server settings for each workspace folder in a multi-root workspace. Such a configuration should spawn a separate php psalm process for each workspace folder, allowing each workspace to operate using different php versions, different psalm.xml files, etc.
Note: the fixtures folder contains a sample multi-root workspace setup