-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "test" ExecuteCommandOption #10094
Comments
Hey @limarkxx, can you reproduce the issue on https://psalm.dev ? |
It's not possible to instantiate multiple LSP instances there. |
@limarkxx I think we can just remove that. Perhaps it was left by me? If that line is removed does it fail in another place? |
I don't think |
It did not that was me trying to figure out how to get it to work though it shouldnt even show up. Regardless it should be removed along with the test command |
At https://github.com/vimeo/psalm/blob/master/src/Psalm/Internal/LanguageServer/LanguageServer.php#L422
there is
$serverCapabilities->executeCommandProvider = new ExecuteCommandOptions(['test']);
, what appears to be a test-call of the workspace/executeCommand LSP feature.This doesn't affect the first LSP in VSCode, but if you have multiple instances the subsequent LSP clients fail during initialization with
The text was updated successfully, but these errors were encountered: