Disable some block checks without state mgmt #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1224e75.
rauljordan
approved these changes
Apr 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #5498 +/- ##
==========================================
- Coverage 54.44% 45.41% -9.04%
==========================================
Files 307 237 -70
Lines 25311 20207 -5104
==========================================
- Hits 13781 9177 -4604
+ Misses 9533 9373 -160
+ Partials 1997 1657 -340 |
delete-merged-branch
bot
deleted the
disable-sig-check-without-state-mgmt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the new checks in
validateBeaconBlockPubSubrequires uses new state mgmt for generating arbitrary state. We need to think about how apply those checks without new state mgmt. In the mean time, this disables the check when--disable-new-state-mgmt