Add WaitForSynced to beacon node for validator startup #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
prestonvanloon
requested changes
Apr 12, 2020
0xKiwi
force-pushed
the
simplify-validator
branch
from
c067dd6 to
b901b51
Compare
0xKiwi
changed the title
rauljordan
approved these changes
Apr 16, 2020
terencechain
approved these changes
Apr 16, 2020
…simplify-validator
|
Please wait to merge new features until after Topaz |
0xKiwi
added
Blocked
prestonvanloon
added
OK to merge
and removed
Blocked
prestonvanloon
approved these changes
Apr 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #5366 +/- ##
==========================================
+ Coverage 40.82% 44.77% +3.95%
==========================================
Files 237 237
Lines 20158 20864 +706
==========================================
+ Hits 8229 9342 +1113
+ Misses 10414 9861 -553
- Partials 1515 1661 +146 |
terencechain
added a commit
that referenced
this pull request
Apr 18, 2020
This reverts commit 1224e75.
prylabs-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 18, 2020
* Revert "Add WaitForSynced to beacon node for validator startup (#5366)" This reverts commit 1224e75. * Merge branch 'master' of github.com:prysmaticlabs/prysm * Revert "Add Separate Network Config (#5454)" This reverts commit 28733f2. * Save blocks to db before generating state * Revert "Revert "Add Separate Network Config (#5454)"" This reverts commit d43c2b7. * Revert "Revert "Add WaitForSynced to beacon node for validator startup (#5366)"" This reverts commit 927d8d9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5345 by reducing
WaitForChainstartandWaitForSynctoWaitForSynced, also making the validator startup more reliable. as previously the beacon node was not ready when the validator made requests to it.Confirmed in runtime:
Old Startup:
New Startup: