Fix Randao Reveal Bug #1801
Merged
Fix Randao Reveal Bug #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
- Coverage 71.65% 71.45% -0.21%
==========================================
Files 104 104
Lines 7388 7315 -73
==========================================
- Hits 5294 5227 -67
+ Misses 1610 1605 -5
+ Partials 484 483 -1 |
rauljordan
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug via: ethereum/consensus-specs#713
We are suppose to xor
hash(block.randao_reveal)notblock.randao_reveal, therefore it's 32 bytes entropy not 96 bytes entropy