Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix randao mixes type, bytes32 like in function and state spec #713

Merged
merged 1 commit into from
Mar 3, 2019

Conversation

protolambda
Copy link
Collaborator

Simple fix: looks like the state container definition and function say latest_randao_mixes should be a Bytes32:

'latest_randao_mixes': ['bytes32'],

...

def get_randao_mix(state: BeaconState,
                   epoch: Epoch) -> Bytes32:

But the genesis list was initialized with empty signatures (96 bytes).

@protolambda
Copy link
Collaborator Author

Wait, I see it was ZERO_HASH previously, why was it changed, but not elsewhere?

@protolambda
Copy link
Collaborator Author

See #654

@JustinDrake
Copy link
Collaborator

Thanks @protolambda 👍

(Oh boy, I approved that bad PR! cc @terenc3t)

@JustinDrake JustinDrake self-requested a review March 2, 2019 19:56
@terencechain
Copy link
Contributor

Thanks @protolambda 👍

(Oh boy, I approved that bad PR! cc @terenc3t)

My bad! I thought we were xor'ing block.randao_reveal but it's actually hash(block.randao_reveal) 😟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants