-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Proposer Slots for Duties #121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
terencechain,
prestonvanloon,
0xKiwi,
farazdagi,
nisdas and
shayzluf
April 7, 2020 20:55
terencechain
approved these changes
Apr 7, 2020
prylabs-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 14, 2020
* change domain response (#109) * Merge branch 'master' of https://github.com/prysmaticlabs/ethereumapis into v0.10.1 * regen proto * Add proposer index * Gen proto * Sync with v0.10 * Update aggregation apis * New pb * update api for better usage * Better definitions * Merge commit '25f267e475788bf8e5e01cb9d73cfd0c87020822' into spec-v0.11 * update proto files * Merge branch 'master' into spec-v0.11 * Add subscribe method for committee ID subnet (#118) * Add SubscribeCommitteeSubnet and CommitteeSubnetSubscribeRequest * Comments * Update validator.proto * Merge branch 'master' into spec-v0.11 * Update `SubscribeCommitteeSubnets` to batch (#120) * Update to batch * Proto * Rename Fork to ForkDefinition (#119) Co-authored-by: Raul Jordan <[email protected]> * Revert * Merge conflict * Multiple Proposer Slots for Duties (#121) * apply items * multiple proposers * workspace changes * no space * Merge branch 'master' of github.com:prysmaticlabs/ethereumapis into spec-v0.11 * Update spec version
rauljordan
added a commit
that referenced
this pull request
Apr 22, 2020
* change domain response (#109) * regen proto * Add proposer index * Gen proto * Update aggregation apis * New pb * update api for better usage * Better definitions * update proto files * Add subscribe method for committee ID subnet (#118) * Add SubscribeCommitteeSubnet and CommitteeSubnetSubscribeRequest * Comments * Update validator.proto * Update `SubscribeCommitteeSubnets` to batch (#120) * Update to batch * Proto * Rename Fork to ForkDefinition (#119) Co-authored-by: Raul Jordan <[email protected]> * Revert * Merge conflict * Multiple Proposer Slots for Duties (#121) * apply items * multiple proposers * workspace changes * no space * Add GetValidatorsRoot * resolve confs * regen Co-authored-by: Nishant Das <[email protected]> Co-authored-by: Terence Tsao <[email protected]> Co-authored-by: Raul Jordan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of v0.11 which includes multiple proposal slots for a validator per epoch, in some cases. It amends
ListValidatorAssignmentsResponse
to returnrepeated uint64 proposer_slots
instead of a single value as well asDutiesResponse
to do the same.