Add subscribe method for committee ID subnet #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
reviewed
Apr 2, 2020
eth/v1alpha1/validator.proto
Outdated
| // and beacon node serving aggregator can join the subnet. | ||
| rpc SubscribeCommitteeSubnet(CommitteeSubnetSubscribeRequest) returns (google.protobuf.Empty) { | ||
| option (google.api.http) = { | ||
| post: "/eth/v1alpha1/validator/subscribe" |
There was a problem hiding this comment.
this gateway endpoint isnt very descriptive, maybe validator/subnet/subscribe?
rauljordan
approved these changes
Apr 3, 2020
prylabs-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 14, 2020
* change domain response (#109) * Merge branch 'master' of https://github.com/prysmaticlabs/ethereumapis into v0.10.1 * regen proto * Add proposer index * Gen proto * Sync with v0.10 * Update aggregation apis * New pb * update api for better usage * Better definitions * Merge commit '25f267e475788bf8e5e01cb9d73cfd0c87020822' into spec-v0.11 * update proto files * Merge branch 'master' into spec-v0.11 * Add subscribe method for committee ID subnet (#118) * Add SubscribeCommitteeSubnet and CommitteeSubnetSubscribeRequest * Comments * Update validator.proto * Merge branch 'master' into spec-v0.11 * Update `SubscribeCommitteeSubnets` to batch (#120) * Update to batch * Proto * Rename Fork to ForkDefinition (#119) Co-authored-by: Raul Jordan <[email protected]> * Revert * Merge conflict * Multiple Proposer Slots for Duties (#121) * apply items * multiple proposers * workspace changes * no space * Merge branch 'master' of github.com:prysmaticlabs/ethereumapis into spec-v0.11 * Update spec version
rauljordan
added a commit
that referenced
this pull request
Apr 22, 2020
* change domain response (#109) * regen proto * Add proposer index * Gen proto * Update aggregation apis * New pb * update api for better usage * Better definitions * update proto files * Add subscribe method for committee ID subnet (#118) * Add SubscribeCommitteeSubnet and CommitteeSubnetSubscribeRequest * Comments * Update validator.proto * Update `SubscribeCommitteeSubnets` to batch (#120) * Update to batch * Proto * Rename Fork to ForkDefinition (#119) Co-authored-by: Raul Jordan <[email protected]> * Revert * Merge conflict * Multiple Proposer Slots for Duties (#121) * apply items * multiple proposers * workspace changes * no space * Add GetValidatorsRoot * resolve confs * regen Co-authored-by: Nishant Das <[email protected]> Co-authored-by: Terence Tsao <[email protected]> Co-authored-by: Raul Jordan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the subscribe method for committee ID subet