-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/cosmos/ibc-go/v2 from 2.2.0 to 2.3.0 #868
Bump github.com/cosmos/ibc-go/v2 from 2.2.0 to 2.3.0 #868
Conversation
Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.3.0/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.2.0...v2.3.0) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to also require an update to the protos, so one of us will need to take over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to look more into that snapshot.proto
file. I'm not sure if it's gone from cosmos or just from our fork. Might be worth a different PR though, but we'll see.
Looks like I'm not sure why we weren't alerted to the existence of that file previously (specially when doing all the tweaks and automation of that check). But what that means is that, with this change, there's a breaking proto change in the third_party stuff. It's breaking because the file is being removed. From Cosmos-SDK PR 10961, it looks like those messages were moved and the failing breaking proto check was ignored. In my opinion, we should also remove the file. The messages defined in there aren't used anywhere that I can find, and are defined in |
Bumps github.com/cosmos/ibc-go/v2 from 2.2.0 to 2.3.0.
Release notes
Sourced from github.com/cosmos/ibc-go/v2's releases.
... (truncated)
Changelog
Sourced from github.com/cosmos/ibc-go/v2's changelog.
Commits
f808f8a
Update CHANGELOG.md6673fca
Update CHANGELOG.mdac556d0
Update CHANGELOG.md230626d
fix to correctly parse denoms with slashes in the base denom (backport #1451)...6496c80
fix: deprecate AllowUpdateAfter...check (backport #1511) (#1520)ae680c1
chore: Add consensus state heights query (backport #1336) (#1506)d7989f1
chore: improve DenomTrace grpc (backport #1342) (#1502)f10135d
backport #1416 to v2.3.x (#1495)7374d31
Emit channel close event on ordered channel close (backport #1464) (#1474)d82a656
add actual parameter example to denom-trace and denom-hash CLI queries (backp...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)