Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The proto-push workflow is running at the wrong time. #931

Closed
4 tasks
dwedul-figure opened this issue Jul 13, 2022 · 0 comments · Fixed by #932
Closed
4 tasks

The proto-push workflow is running at the wrong time. #931

dwedul-figure opened this issue Jul 13, 2022 · 0 comments · Fixed by #932
Assignees
Labels
bug Something isn't working github_actions Pull requests that update Github_actions code proto Protobuf files work

Comments

@dwedul-figure
Copy link
Contributor

Summary of Bug

The proto-push workflow is running on merges to main instead of as part of a release.

That means that our published protos don't necessarily represent our most recent release. This can also cause our proto checks to fail erroneously.

Example, #868 was merged to main which caused the new proto files to be pushed. But those protos weren't updated in the release/v1.11.x branch. So any PR based on the release/v1.11.x branch now fails the third-party proto breaking check. It's saying that things have been removed from the proto. But in fact, nothing has been removed, it's just that new additions were pushed up for comparison before they were part of a release.

Version

cab33d8b (and also v1.11.1).

Steps to Reproduce

See https://github.com/provenance-io/provenance/actions/runs/2666663928

Proposed Solution

Move that job into the release.yml workflow and utilize the setup/variables in there to do that job during a release (instead of on push to main).


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dwedul-figure dwedul-figure added bug Something isn't working github_actions Pull requests that update Github_actions code proto Protobuf files work labels Jul 13, 2022
@dwedul-figure dwedul-figure self-assigned this Jul 13, 2022
@dwedul-figure dwedul-figure moved this from Todo to In Progress in Provenance Core Protocol Team Jul 13, 2022
Repository owner moved this from In Progress to Done in Provenance Core Protocol Team Jul 14, 2022
@iramiller iramiller moved this from Done to Archive in Provenance Core Protocol Team Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update Github_actions code proto Protobuf files work
Projects
Development

Successfully merging a pull request may close this issue.

1 participant