-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable full pagination support for the metadata OS Locator queries #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RI and OSAllLocators (was that way prior to this change).
Codecov Report
@@ Coverage Diff @@
## main #470 +/- ##
==========================================
+ Coverage 54.02% 54.14% +0.12%
==========================================
Files 149 149
Lines 19159 19116 -43
==========================================
Hits 10351 10351
+ Misses 8021 7978 -43
Partials 787 787
|
dwedul-figure
requested review from
arnabmitra,
channa-figure and
iramiller
as code owners
September 10, 2021 23:29
# Conflicts: # CHANGELOG.md
iramiller
approved these changes
Sep 16, 2021
arnabmitra
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the metadata module's
OSAllLocators
andOSLocatorsByURIRequest
queries to fully support the pagination features.closes: #401
closes: #402
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes