Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Metadata OSAllLocators query to fully utilize the pagination fields. #402

Closed
4 tasks
dwedul-figure opened this issue Jul 29, 2021 · 1 comment · Fixed by #470
Closed
4 tasks
Assignees
Labels
enhancement New feature or request metadata Metadata Module
Milestone

Comments

@dwedul-figure
Copy link
Contributor

Summary

The Metadata module's OSAllLocatorsRequest message contains a cosmos.base.query.v1beta1.PageRequest message, but the module's query_server OSAllLocators method does not use the query.Paginate or query.FilteredPaginate methods. So not all pagination functionality is available on that query, e.g. pagination using a next_key and key.

Problem Definition

Most of the other paginated queries have full pagination support, so not having it here can cause confusion and frustration. Additionally, there's no way to know how many results there are without getting all of them.

Proposal

Refactor the Metadata module's OSAllLocators query to use either the query.Paginate or query.FilteredPaginate function in order to enable full pagination support.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dwedul-figure dwedul-figure added enhancement New feature or request metadata Metadata Module labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metadata Metadata Module
Projects
Development

Successfully merging a pull request may close this issue.

2 participants