Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): heighliner build #2184

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix(ci): heighliner build #2184

merged 1 commit into from
Oct 16, 2024

Conversation

scirner22
Copy link
Contributor

@scirner22 scirner22 commented Oct 16, 2024

Use latest release of heighliner to fix CI process.

  • supports go 1.23
  • fixes libwasm pathing bug

Closes #2185

Summary by CodeRabbit

  • New Features

    • Updated Docker workflow to trigger on specific pull requests and pushes to the main branch.
    • Simplified build process for Docker images.
    • Updated versioning for the heighliner-tag to v1.7.0.
  • Bug Fixes

    • Clarified comments regarding cross-compilation issues.

@scirner22 scirner22 force-pushed the scirner22/fix-heighliner-build branch from 52ec39d to 82826c6 Compare October 16, 2024 00:46
@scirner22 scirner22 force-pushed the scirner22/fix-heighliner-build branch from 82826c6 to b217314 Compare October 16, 2024 00:48
@SpicyLemon SpicyLemon mentioned this pull request Oct 16, 2024
8 tasks
@scirner22 scirner22 marked this pull request as ready for review October 16, 2024 12:36
@scirner22 scirner22 requested a review from a team as a code owner October 16, 2024 12:36
Copy link
Contributor

coderabbitai bot commented Oct 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the GitHub Actions workflow for building and pushing Docker images. It specifies new triggers for pull requests affecting certain files and updates the heighliner-tag version from v1.6.3 to v1.7.0. The pre-build step is removed, and the build process is simplified by eliminating unnecessary commands. The overall structure of the workflow remains consistent, focusing on the Docker image build and push process.

Changes

File Change Summary
.github/workflows/docker.yml Updated workflow triggers, modified heighliner-tag to v1.7.0, removed pre-build step, simplified build-target command.

Assessment against linked issues

Objective Addressed Explanation
Fix heighliner build action failure (#2185)

Possibly related PRs

Suggested reviewers

  • Taztingo
  • SpicyLemon
  • nullpointer0x00

Poem

🐰 In the land of code where rabbits play,
We build our Docker dreams each day.
With tags that change and workflows bright,
Our heighliner hops to new heights!
🥕 Let's celebrate this code delight!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@scirner22 scirner22 merged commit 25ba1be into main Oct 16, 2024
22 of 23 checks passed
@scirner22 scirner22 deleted the scirner22/fix-heighliner-build branch October 16, 2024 12:37
SpicyLemon pushed a commit that referenced this pull request Oct 16, 2024
SpicyLemon added a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heighliner image is broken
3 participants