fix(ci): point to correct provenanced binary in heighliner image #1985
Conversation
WalkthroughThe recent update enhances the GitHub Actions workflow for Docker builds. It includes specifying a custom Dockerfile, adding additional binaries, setting build environment variables, and incorporating build tags. These improvements aim to streamline the Docker build process, making it more flexible and efficient. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
scirner22
force-pushed
the
temp-heighliner-push
branch
from
d87a73c
to
9bd384e
Compare
scirner22
changed the title
scirner22
force-pushed
the
temp-heighliner-push
branch
from
9bd384e
to
ccdc600
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/docker.yml (1 hunks)
Additional comments not posted (3)
.github/workflows/docker.yml (3)
64-64: Correctly specifies the location of theprovenancedbinary, addressing the issue of the binary not being found in the image.
59-59: Ensure the 'cosmos' Dockerfile exists and is correctly configured for building theprovenancedbinary.Verification successful
The 'cosmos' Dockerfile exists and is correctly configured for building the
provenancedbinary.
- The Dockerfile includes multiple
FROMstatements for different build stages and architectures.- It contains
COPYcommands to ensure theprovenancedbinary is included in the final image.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and content of the 'cosmos' Dockerfile. # Test: Search for the Dockerfile and display its content. Expect: Dockerfile exists and contains relevant build instructions. fd Dockerfile --exec cat {} \; | grep -i "FROM"Length of output: 2503
66-68: Ensure the specified build environment variables and tags are appropriate and up-to-date for building theprovenancedbinary.Verification successful
The build environment variables and tags specified in the workflow file are indeed referenced in the Makefile and documentation. This confirms that the settings are appropriate and up-to-date for building the
provenancedbinary.
WITH_LEDGER: Enables/Disables building with Ledger hardware wallet support.BUILD_TAGS: Any extra-tagsto supply to thego buildorgo installinvocations.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the appropriateness of build environment variables and tags. # Test: Check the project documentation or configuration files to confirm these settings. Expect: Settings are recommended and up-to-date. cat README.md | grep -i "build environment"Length of output: 45
Script:
#!/bin/bash # Description: Verify the appropriateness of build environment variables and tags. # Test: Check Dockerfiles for build environment variables and tags. fd Dockerfile | xargs cat | grep -iE 'WITH_LEDGER|WITH_CLEVELDB|BUILD_TAGS' # Test: Check Makefiles for build environment variables and tags. fd Makefile | xargs cat | grep -iE 'WITH_LEDGER|WITH_CLEVELDB|BUILD_TAGS' # Test: Check other documentation files for build environment variables and tags. fd .md | xargs cat | grep -iE 'WITH_LEDGER|WITH_CLEVELDB|BUILD_TAGS'Length of output: 1048
The
heighliner-build-actionmakes it seem like theheighlinerrepochains.yamlis used as a default and overrides can be provided. In practice I was seeing a problem whereprovenancedcould not be found on the recently built image. This adds the fields that exist inchains.yamlso this workflow itself can now be thought of as the canonical configuration rather than thechains.yaml.Tests
docker run provenanceio/provenance@sha256:194ec608f295d753dd936ca6d12046ffb0308651735d66fc7fc594936f8de33e /bin/sh -c "provenanced init --chain-id testing -t network-1 ; provenanced start -t"Summary by CodeRabbit