Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of semi-edge-cases #199

Merged
merged 4 commits into from
Feb 2, 2023

Commits on Oct 14, 2021

  1. Configuration menu
    Copy the full SHA
    058b70e View commit details
    Browse the repository at this point in the history
  2. Avoid throwing in ProtoBufMarshallerFactory.CanSerialize

    There is at least one situation where the underlying protobuf TypeModel
    throws a NotSupportedException : when asking about an array of arrays.
    While this seems doubtful (it should simply return false), it is easy
    enough to prevent this from trashing the whole service.
    lanfeust69 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    21c1867 View commit details
    Browse the repository at this point in the history
  3. Remove remnant of old code

    No longer any reason to handle delegates specifically : it will be done
    naturally by the marshallerCache (and who knows, maybe it *can*
    serialize some delegates !).
    Moreover, this could misinterpret a signature as valid without parameter,
    with somewhat weird consequences.
    lanfeust69 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    f2784fd View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Configuration menu
    Copy the full SHA
    32fa770 View commit details
    Browse the repository at this point in the history