Fix a couple of semi-edge-cases #199
Conversation
There was a problem hiding this comment.
IDisposable- makes sense, niceCanSerialize- should probably fix in protobuf-net too, but this works- but: what's the scenario for delegates? in what scenario would we expect/need them to work?
Looking good, though; liking where this is going
Recommendation: nameof(IDisposable.Dispose) instead of "Dispose"
No scenario, the code was from before the use of the The real (small) issue is that we happen to have a Wcf operation that did have an
|
There is at least one situation where the underlying protobuf TypeModel throws a NotSupportedException : when asking about an array of arrays. While this seems doubtful (it should simply return false), it is easy enough to prevent this from trashing the whole service.
No longer any reason to handle delegates specifically : it will be done naturally by the marshallerCache (and who knows, maybe it *can* serialize some delegates !). Moreover, this could misinterpret a signature as valid without parameter, with somewhat weird consequences.
lanfeust69
force-pushed
the
fix_exceptions
branch
from
5a1608d
to
f2784fd
Compare
|
this was long overdue - entirely my fault; merged with thanks - should be in 1.1 |
These could result in not binding a service at all, when only one method is at fault, or throwing unexpectedly on the client side.