Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.7.0 #181

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Release/0.7.0 #181

merged 3 commits into from
Feb 7, 2024

Conversation

Swandog
Copy link
Contributor

@Swandog Swandog commented Feb 7, 2024

Bumped versions, filled out the changelogs, and updated the citation

@Swandog Swandog self-assigned this Feb 7, 2024
@Swandog Swandog requested a review from a team as a code owner February 7, 2024 00:15
lace_utils = { path = "lace_utils", version = "0.3.0" }
lace_stats = { path = "lace_stats", version = "0.3.0" }
lace_codebook = { path = "lace_codebook", version = "0.6.0", default_features=false}
lace_geweke = { path = "lace_geweke", version = "0.3.0" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I didn't change the version of lace_consts since the only change in it was a PATCH version bump in the rv dependency. I think that shouldn't require publishing a new version since Cargo should do the right thing and update the patch by default when people build it.

Copy link
Contributor

@schmidmt schmidmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good. Should we write a tool to check the versions to ensure they're all in sync?

@Swandog
Copy link
Contributor Author

Swandog commented Feb 7, 2024

It all looks good. Should we write a tool to check the versions to ensure they're all in sync?

The versions of the Rust subcrates should not be in sync with each other (we discussed this awhile back and Bax made the executive decision to not sync them)
Cargo will already fail if the dependency specifications do not reference the correct version (e.g., when I bumped lace_utils to 0.3.0, cargo check failed for the crates (like lace) that depended on it until I bumped their dependency specification to 0.3.0)
The Rust and Python crates do not need to be synced with each other, as per discussion with Bax earlier
The pylace/Cargo.toml and pylace/pyproject.toml versions DO need to be in sync with each other and there is already a step checking that in the release process

@Swandog Swandog merged commit 408d4de into master Feb 7, 2024
26 checks passed
@Swandog Swandog deleted the release/0.7.0 branch February 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants