Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generator docker image build #952

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Aug 17, 2023

Use the setup_build_environment orb command to correctly setup remote
docker for building the generator docker image.

  • Fix default branch matching.

Fixes: #944

@SuperQ SuperQ requested a review from roidelapluie August 17, 2023 05:15
@SuperQ SuperQ force-pushed the superq/fix_generator_docker branch 2 times, most recently from 087b5e5 to 5ae2e7e Compare August 17, 2023 12:06
Use the setup_build_environment orb command to correctly setup remote
docker for building the generator docker image.
* Fix default branch matching.

Fixes: #944

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/fix_generator_docker branch from 5ae2e7e to 8c88eed Compare August 17, 2023 12:07
@SuperQ SuperQ requested a review from simonpasquier August 17, 2023 12:09
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 711f615 into main Aug 17, 2023
@SuperQ SuperQ deleted the superq/fix_generator_docker branch August 17, 2023 12:42
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
Use the setup_build_environment orb command to correctly setup remote
docker for building the generator docker image.
* Fix default branch matching.

Fixes: prometheus#944

Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Hub snmp-generator outdated
2 participants