Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Hub snmp-generator outdated #944

Closed
llamafilm opened this issue Aug 14, 2023 · 3 comments · Fixed by #952 or #955
Closed

Docker Hub snmp-generator outdated #944

llamafilm opened this issue Aug 14, 2023 · 3 comments · Fixed by #952 or #955

Comments

@llamafilm
Copy link

The last several versions of snmp-generator are missing from Docker Hub, as compared with snmp-exporter. They should probably be kept in parity. Based on the release dates, I would guess that snmp-generator:latest refers to v0.21.0.

https://hub.docker.com/r/prom/snmp-generator/tags
https://hub.docker.com/r/prom/snmp-exporter/tags

@irctrakz
Copy link

Especially amusing that with v0.23.0 the old snmp.yml is no longer correct per https://github.com/prometheus/snmp_exporter/blob/main/auth-split-migration.md

SuperQ added a commit that referenced this issue Aug 17, 2023
Use the setup_build_environment orb command to correctly setup remote
docker for building the generator docker image.
* Fix default branch matching.

Fixes: #944

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this issue Aug 17, 2023
Use the setup_build_environment orb command to correctly setup remote
docker for building the generator docker image.
* Fix default branch matching.

Fixes: #944

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ reopened this Aug 17, 2023
@SuperQ
Copy link
Member

SuperQ commented Aug 17, 2023

Ok, I fixed at least the main tag publishing.

@SuperQ
Copy link
Member

SuperQ commented Aug 17, 2023

I tracked down the last few bugs in the publishing steps. This will now correctly publish and tag releases and the latest tag.

stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this issue Oct 27, 2023
Use the setup_build_environment orb command to correctly setup remote
docker for building the generator docker image.
* Fix default branch matching.

Fixes: prometheus#944

Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants