[kube-prometheus-stack] Minify Grafana Dashboards and Update CRDs to 0.65.1 #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
minify-json-dashboards
branch
from
f451310 to
d85d8ee
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
minify-json-dashboards
branch
from
d85d8ee to
a74dfbe
Compare
jkroepke
changed the title
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
minify-json-dashboards
branch
from
440825e to
9c645d0
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
commented
May 23, 2023
Comment on lines
-124
to
-129
| # fix drilldown links. See https://github.com/kubernetes-monitoring/kubernetes-mixin/issues/659 | ||
| for row in content_struct['rows']: | ||
| for panel in row['panels']: | ||
| for style in panel.get('styles', []): | ||
| if 'linkUrl' in style and style['linkUrl'].startswith('./d'): | ||
| style['linkUrl'] = style['linkUrl'].replace('./d', '/d') |
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
minify-json-dashboards
branch
from
9026331 to
7e9b291
Compare
jkroepke
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
|
@jkroepke this is an awesome find for now :) I think we are missing the RBAC to access those CRDs but I will take a better look today |
|
@QuentinBisson Maintainers are allowed to edit this pull request is enabled, so feel free to commit into this. |
Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
force-pushed
the
minify-json-dashboards
branch
from
a47cdf8 to
181f72d
Compare
Signed-off-by: Quentin Bisson <[email protected]>
|
@jkroepke Done i'll test this now |
jkroepke
commented
May 23, 2023
charts/kube-prometheus-stack/templates/prometheus-operator/clusterrole.yaml
Show resolved
Hide resolved
QuentinBisson
approved these changes
May 23, 2023
|
Thank you @jkroepke |
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
May 31, 2023
…0.65.1 (prometheus-community#3416) * [kube-prometheus-stack] Minify Grafana Dashboards Signed-off-by: Jan-Otto Kröpke <[email protected]> * [kube-prometheus-stack] Minify Grafana Dashboards Signed-off-by: Jan-Otto Kröpke <[email protected]> * [kube-prometheus-stack] Update CRDs Signed-off-by: Jan-Otto Kröpke <[email protected]> * [kube-prometheus-stack] Test remove dashboards Signed-off-by: Jan-Otto Kröpke <[email protected]> * [kube-prometheus-stack] revert Test remove dashboards Signed-off-by: Jan-Otto Kröpke <[email protected]> * [kube-prometheus-stack] minify CoreDNS dashboard Signed-off-by: Jan-Otto Kröpke <[email protected]> * Add missing rbac and readme Signed-off-by: QuentinBisson <[email protected]> --------- Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: QuentinBisson <[email protected]> Signed-off-by: Quentin Bisson <[email protected]> Co-authored-by: QuentinBisson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Reduce the helm chart size (see #3267 (comment))
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Size of the helm release on branch main
Size of the helm release on branch minify-json-dashboards
Checklist
[prometheus-couchdb-exporter])